Fix bounds-checking bug in floatToRationalCast #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbackhouse
force-pushed
the
fix-issue-2352
branch
from
ecbe2fb
to
9ba87ae
Compare
This was referenced Sep 15, 2022
…l?id=51241 Fix bounds checking bug.
kevinbackhouse
force-pushed
the
fix-issue-2352
branch
from
9ba87ae
to
ca20c94
Compare
Codecov Report
@@ Coverage Diff @@
## main #2353 +/- ##
==========================================
- Coverage 63.51% 63.51% -0.01%
==========================================
Files 119 119
Lines 20624 20622 -2
Branches 10233 10232 -1
==========================================
- Hits 13100 13098 -2
Misses 5395 5395
Partials 2129 2129
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kevinbackhouse
added
bug
OSS-Fuzz
neheb
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2352
I reversed the order of the if-then-else cascade to get the bounds checking correct.